fix: confirmation window is displayed after save for dropdown#2429
fix: confirmation window is displayed after save for dropdown#2429cmltaWt0 wants to merge 4 commits intoopenedx:masterfrom
Conversation
"No answer specified" confirmation window is displayed all the time after second save for dropdown.
openedx-webhooks
added
open-source-contribution
|
Thanks for the pull request, @cmltaWt0! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2429 +/- ##
========================================
Coverage 94.64% 94.64%
========================================
Files 1187 1187
Lines 26196 26196
Branches 5675 5833 +158
========================================
Hits 24792 24792
+ Misses 1341 1333 -8
- Partials 63 71 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| const title = simpleTextAreaProblems.includes(problemType) ? answer.title : answerTitles[answer.id]; | ||
| if (title?.length > 0) { | ||
| const title = simpleTextAreaProblems.includes(problemType) ? answer.title.toString() : answerTitles[answer.id]; | ||
| if (title.length > 0) { |
There was a problem hiding this comment.
Are we certain that title is always going to be defined? There's no type information here so I don't really know, but it seems safer to leave it as title?.length just in case.
| if (answer.correct) { | ||
| const title = simpleTextAreaProblems.includes(problemType) ? answer.title : answerTitles[answer.id]; | ||
| if (title?.length > 0) { | ||
| const title = simpleTextAreaProblems.includes(problemType) ? answer.title.toString() : answerTitles[answer.id]; |
There was a problem hiding this comment.
This fixes the problem, but it seems like the real problem is that answer.title is a number in the first place. Shouldn't we try to prevent title from being set to a non-string value in the first place, rather than fixing it here?
I think the root problem might be on this line where the XML parser sometimes returns a number for the #text value. Could we coerce it to a string there instead?
|
Hi @cmltaWt0! Just checking to see if this pull request is still in progress? |
Yes. I just didn't have a chance to resolve the comments yet. |
|
@cmltaWt0 friendly reminder about this PR. |
Thanks a lot and really sorry for the delay - completely out of focus. Let me update you by the end of this week with the solution. |
|
@bradenmacdonald to speed up the work @filippovskii09 will continue the PR this week. |
|
Closing in favor of #2752 |
5 participants
Description
"No answer specified" confirmation window is displayed all the time after the second save for dropdown.
Steps to Reproduce:
UnitProblemDropdownSaveEditfor problem againSaveIt's a re-creation of #1278